Support HHVM's PHP7 mode

Was calling md5(int), which is invalid.
hhvm · Jun 26, 2017 · d9171c8 · d9171c8
1 parent 25c62c8
commit d9171c8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.travis.sh b/.travis.sh
@@ -8,3 +8,6 @@ curl https://getcomposer.org/installer | hhvm -d hhvm.jit=0 --php -- /dev/stdin
 cd /var/source
 hhvm -d hhvm.jit=0 /usr/local/bin/composer install
 hhvm -d hhvm.jit=0 vendor/bin/phpunit tests/
+if [ $(hhvm --php -r 'echo HHVM_VERSION_ID;' 2>/dev/null) -ge 32002 ]; then
+  hhvm -d hhvm.php7.all=1 -d hhvm.jit=0 vendor/bin/phpunit tests/
+fi
diff --git a/src/html/XHPBaseHTMLHelpers.php b/src/html/XHPBaseHTMLHelpers.php
@@ -45,7 +45,7 @@ public function requireUniqueID(): string {
     $id = /* UNSAFE_EXPR */ $this->:id;
     if ($id === null || $id === '') {
       try {
-        $this->setAttribute('id', $id = substr(md5(mt_rand(0, 100000)), 0, 10));
+        $this->setAttribute('id', $id = bin2hex(random_bytes(5)));
       } catch (XHPInvalidAttributeException $error) {
         throw new XHPException(
           'You are trying to add an HTML id to a(n) '.