Skip to content

Commit

Permalink
Remove In-tree C# Bindings (#1302)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1302

These C# bindings were contributed as part of ff8f17a. They have occasionally been refreshed, but has never really had validation it built continuously, or dedicated maintenance.

There has been a surge of work with #1207 to try to modernize the build for these, but checking with jkoritzinsky I'm not sure either of us have the time to commit to supporting these at the same level as other bindings.

Some well-known projects like Unity had already abandoned this set of bindings for their own. Unity-Technologies/UnityCsReference@016297e#diff-c85198aaac9095a5446ed00b0fba8025072d235b2b69dea8aad85abc64a83e1e

So, as part of the work for an official OSS release, and really trying to define what is deprecated, and what we will try to support, I am removing the in-tree C# bindings from Yoga.

In the past, gaps in Yoga bindings we haven't supported have led to new bindings with dedicated maintainers e.g. [FlexLayout](https://github.com/layoutBox/FlexLayout), [yoga-rs](https://github.com/bschwind/yoga-rs), [yoga-wasm-web](https://github.com/shuding/yoga-wasm-web). My hope is that by removing the C# bindings that we are not supporting, we free up the opportunity for a new version to become the defacto.

Reviewed By: javache

Differential Revision: D46425886

fbshipit-source-id: df964c4d55adf93c4d1e82c104e74ca5ad181612
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Jun 5, 2023
1 parent 1ab0c7b commit 5e74e20
Show file tree
Hide file tree
Showing 194 changed files with 2 additions and 30,985 deletions.
272 changes: 0 additions & 272 deletions csharp/.gitignore

This file was deleted.

1 change: 0 additions & 1 deletion csharp/Android/.gitignore

This file was deleted.

This file was deleted.

24 changes: 0 additions & 24 deletions csharp/Android/Facebook.Yoga.Android.Tests/MainActivity.cs

This file was deleted.

This file was deleted.

Empty file.

0 comments on commit 5e74e20

Please sign in to comment.