Even faster flexbox #123
Merged
Even faster flexbox #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, Java doesn't have any build-time inlining solution and method invocations do have a big performance impact on Android. This changes Java's transpiler to inline almost all internal methods at build time. This gives us a 30% performance win in my local benchmarks. There's a drawback from moving code to the transpiler but I think this is worth it (given the massive perf wins here) and the inlined methods are fairly simple.
It turns the spacing resolution in Java is fairly expensive right now because it doesn't a bunch of unnecessary checks in the array, especially when the Spacing instance doesn't have any values set on it. This diff changes Spacing to store the state of the defined values in a bitwise flag so that padding/border/margin queries are a lot faster during layout calculations. This gives us as extra 20% performance win in my local benchmarks on Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has a series of changes on top #121 and #122 that makes css-layout an extra 50% faster in my benchmarks on Android.
It does two things: