Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS build on Windows #1648

Closed
wants to merge 1 commit into from
Closed

Fix JS build on Windows #1648

wants to merge 1 commit into from

Commits on Apr 17, 2024

  1. Fix JS build on Windows (facebook#1648) 

    Summary:

Node made a breaking change in a security release for 18/20 where `spawn()` no longer loads `.bat` files by default. nodejs/node@69ffc6d. Execute command in shell.

Differential Revision: D56230965
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    362633a View commit details
    Browse the repository at this point in the history