Fix firefox iframe timing issue in test runners, fixes #25 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanseddon
force-pushed
the
iframe_firefox_fix
branch
from
f8dc5fe
to
1ad94fa
Compare
|
Thanks! I couldn't figure out a reliable way to avoid the timing issues :) |
vjeux
added a commit
that referenced
this pull request
Feb 5, 2015
Fix firefox iframe timing issue in test runners, fixes #25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All browsers except chrome have timing issues when dynamically creating and injecting content inside an iframe, see blog post if you're interested in why. Boils down to waiting for the
readyStateto becompletebefore appending to the DOM.All tests pass in Firefox except 2, not sure how to fix these so any help would be good.
I also changed the use of
innerTexttotextContentas Firefox refused to render the CSS string and in Chrome it added a bunch of<br>tags and somehow the CSS parser is forgiving enough to still work!