fix gradle compliation #925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amir-shalem
force-pushed
the
export-D17274226
branch
from
a1f0500
to
4d82c53
Compare
Summary: Pull Request resolved: facebook#925 Gradle is failing to compile yoga for two reasons: 1. Ever since `YogaNodeJNIPhantomRefs` was introduced which uses `DestructorThread.Destructor` from fbjni which was the first direct Java dependency from yoga java to fbjni java code. 2. Adding a missing gradle endpoint for `testutil` since it is now required for yoga unit-tests Differential Revision: D17274226 fbshipit-source-id: 9a4919f1bb72ac1f52b6b32ce7acbff435d587e4
amir-shalem
force-pushed
the
export-D17274226
branch
from
4d82c53
to
d14e2cd
Compare
|
This pull request has been merged in 31de91b. |
tobster-de
pushed a commit
to RECOMGmbH/Yoga
that referenced
this pull request
Oct 30, 2020
Summary: Pull Request resolved: facebook#925 Gradle is failing to compile yoga for two reasons: 1. Ever since `YogaNodeJNIPhantomRefs` was introduced which uses `DestructorThread.Destructor` from fbjni which was the first direct Java dependency from yoga java to fbjni java code. 2. Adding a missing gradle endpoint for `testutil` since it is now required for yoga unit-tests Reviewed By: SidharthGuglani Differential Revision: D17274226 fbshipit-source-id: 3df9648321162d34f81fd3675ca1474e8a1c6d3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Gradle is failing to compile yoga for two reasons:
Ever since
YogaNodeJNIPhantomRefswas introduced which usesDestructorThread.Destructorfrom fbjni which was the first direct Java dependency from yoga java to fbjni java code.Adding a missing gradle endpoint for
testutilsince it is now required for yoga unit-testsDifferential Revision: D17274226