incorrect pointer tested against NULL

[Banzai24-yht]

using cppcheck on the source code :

lib/common/threading.c:79:6: warning: Either the condition '!thread' is redundant or there is possible null pointer dereference: thread. [nullPointerRedundantCheck]
    *thread = NULL;
     ^
lib/common/threading.c:94:9: note: Assuming that condition '!thread' is not redundant
    if (!thread) {
        ^
lib/common/threading.c:79:6: note: Null pointer dereference
    *thread = NULL;
     ^
lib/common/threading.c:93:6: warning: Either the condition '!thread' is redundant or there is possible null pointer dereference: thread. [nullPointerRedundantCheck]
    *thread = (HANDLE)_beginthreadex(NULL, 0, worker, &thread_param, 0, NULL);
     ^
lib/common/threading.c:94:9: note: Assuming that condition '!thread' is not redundant
    if (!thread) {
        ^
lib/common/threading.c:93:6: note: Null pointer dereference
    *thread = (HANDLE)_beginthreadex(NULL, 0, worker, &thread_param, 0, NULL);
     ^

I think the correction may be :

diff --git a/lib/common/threading.c b/lib/common/threading.c
index ca155b9b..ba76e613 100644
--- a/lib/common/threading.c
+++ b/lib/common/threading.c
@@ -91,7 +91,7 @@ int ZSTD_pthread_create(ZSTD_pthread_t* thread, const void* unused,

     /* Spawn thread */
     *thread = (HANDLE)_beginthreadex(NULL, 0, worker, &thread_param, 0, NULL);
-    if (!thread) {
+    if (!*thread) {
         ZSTD_pthread_mutex_destroy(&thread_param.initialized_mutex);
         ZSTD_pthread_cond_destroy(&thread_param.initialized_cond);
         return errno;

[Cyan4973]

Indeed, I think the analysis is correct.
To be fixed