Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zstdcat to follow symbolic links #1604

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Make zstdcat to follow symbolic links #1604

merged 2 commits into from
Apr 30, 2019

Conversation

vejnar
Copy link
Contributor

@vejnar vejnar commented Apr 27, 2019

Since #1520 has been merged, commands like zstdcat properly detect symbolic links on Linux. But the consequence is that they output nothing when executed on a symbolic link. According to the manual, zstdcat includes -f, which should follow symbolic links. This is also how most *cat commands like zcat behave.

Please comment and I would be glad if you could consider this request for merging into master. Thanks.
Charles

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@terrelln terrelln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

Note for others that see this issue, until the next zstd release this can be worked around by using with zstdcat -f.

@terrelln
Copy link
Contributor

Oh, nearly forgot! Would you mind adding a test to tests/playTests.sh that makes sure it works zstdcat works with symlinks? There is already a section that tests zstdcat, so you can just append a test there.

If you don't have the time, let me know and I can add the test myself. If I don't hear back in a few days I'll go ahead and merge and add the test.

@terrelln terrelln merged commit 69baaee into facebook:dev Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants