Reduce test time on TravisCI #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by allowing parallel build of units, and reducing optimization levels. Parallel build is only effective on "recent" versions of `zstd`, as previously, the list of units was passed as a list of source files, which is something neither `make` nor `gcc` can parallelize. So its impact is mildly effective (-20%). Reducing optimization level to `-O1` makes compilation much faster. It also makes runtime slower, but in this test, compilation time dominates run time. The savings are very significant (-50%). On my test system, it reduces the length of this test from 13mn to 5mn.
This was ~30mn, by far the longest run on travisCI. That's because it re-analyzes multiple times the same files (library files notably). It also performs actions that make no sense for the static analyzer purpose, such as building the single-file library. Reduced time spent in this test by reducing its scope : just build the CLI, and obviously the library along it. These are the only ones that really deserve to be analyzed. Unfortunately, it still results in a number of false positives when using newer versions of scanbuild (each version of scanbuild generates a different list of false positives). These will have to be fixed before transfering to Github Actions.
Cyan4973
changed the title
since it fails on Github Actions specifically. The test is run on TravisCI for the time being. Its duration has been reduced to ~6mn anyway.
|
Note : the flaky failing test is unrelated to this PR : There seems to be an issue in This test has been failing for a while now, but because the issue is transient, and apparently specific to |
that are being transfered to GA in #2758. This represents a saving of ~25mn of cpu time on TravisCI.
senhuang42
approved these changes
Aug 31, 2021
| @@ -200,6 +200,18 @@ jobs: | |||
| make clean && make -j all MOREFLAGS="-Werror -DZSTD_NO_INLINE -DZSTD_STRIP_ERROR_STRINGS" | |||
| make clean && make check MOREFLAGS="-Werror -DZSTD_NO_INLINE -DZSTD_STRIP_ERROR_STRINGS" | |||
|
|
|||
| # This test currently fails on Github Actions specifically. | |||
There was a problem hiding this comment.
I think this is probably because GH Actions runners are not ttys. I believe there is a third-party GH action that creates a tty now, so I can go back and migrate the tests that were failing because it wasn't a tty at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this was initially an attempt at transferring more tests from TravisCI into Github Actions.
But with additional complexities along the way, I decided to cut down the scope of this PR at just making TravisCI tests shorter.
More test transfers will happen in other PR(s).
qemutests, transferred to Github Actions in added qemu tests #2758This reduces cpu time spent on TravisCI by ~90mn per tested commit (from 2h35mn to 1h05mn).