[test] Test that the exec-stack bit isn't set on libzstd.so #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyan4973
reviewed
Dec 1, 2021
tests/libzstd_builds.sh
Outdated
| nm $DIR/../lib/libzstd.a | $GREP "\.o" > tmplog | ||
| isPresent "zstd_compress.o" | ||
| isPresent "zstd_decompress.o" | ||
| isPresent "zdict.o" | ||
| isPresent "zstd_v07.o" | ||
| mustBeAbsent "zbuff_compress.o" | ||
| $RM $DIR/../lib/libzstd.a tmplog | ||
| rm tmplog |
There was a problem hiding this comment.
minor : consistency : rm -> $RM
Cyan4973
approved these changes
Dec 1, 2021
Tests that libzstd.so doesn't have the exec-stack bit set using readelf. If the stack is marked executable systemd will refuse to link against zstd. We now test that it isn't set on every PR. Adds a test for PR facebook#2857 Fixes Issue facebook#2865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that libzstd.so doesn't have the exec-stack bit set using
readelf. If the stack is marked executable systemd will refuse
to link against zstd. We now test that it isn't set on every PR.
Adds a test for PR #2857
Fixes Issue #2865