simplify SSE implementation of row_lazy match finder #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostly for maintenance convenience. Performance wise, there is very little change, slightly faster for slog 3 & 4, neutral or very slightly negative for slot 5 & 6.
Cyan4973
changed the title
felixhandte
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor is proposed mostly for maintenance convenience.
Performance wise, there is very little change,
I measure it slightly faster for slog 3 & 4 (~+2%)
but neutral or very slightly negative for slot 5 & 6 (< 1 %)
on both
gccandclang.It feels like an okay side effect
(we want to improve speed more for faster modes).
But the real goal was to reduce the amount of intrinsic code.
This approach could not be easily extended to
NEONbecause the current implementation is significantly different between the 16, 32, and 64 entries.