Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix and new features for largeNbDicts benchmark #3063

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Bugfix and new features for largeNbDicts benchmark #3063

merged 1 commit into from
Feb 11, 2022

Conversation

embg
Copy link
Contributor

@embg embg commented Feb 11, 2022

  • Fix crash in dictionary creation logic (in the largeNbDicts tool, not zstd)
  • Add --dict-content-type and --dict-attach-pref CLI options
  • Update docs

@embg embg merged commit 970460f into facebook:dev Feb 11, 2022
@embg embg deleted the largeNbDicts branch February 11, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

@felixhandte felixhandte felixhandte approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@embg @Cyan4973 @felixhandte @facebook-github-bot