Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop -E flag in sed #3245

Merged
merged 1 commit into from
Sep 19, 2022
Merged

drop -E flag in sed #3245

merged 1 commit into from
Sep 19, 2022

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Aug 19, 2022

This flag is not universally supported in sed, and there's no regex replacement going on anwyays, it's literal text replacement.

-E is missing in sed version 4.1.5 for example, as found on some ancient centos image I'm working with.

@facebook-github-bot
Copy link

Hi @haampie!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Cyan4973 Cyan4973 self-assigned this Aug 20, 2022
@Cyan4973 Cyan4973 merged commit e9e8875 into facebook:dev Sep 19, 2022
@haampie haampie deleted the fix/SED_ERE_OPT branch September 19, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants