[contrib][linux-kernel] Generate SPDX license identifiers #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `--spdx` option to the freestanding script to prefix
files with a line like (for `.c` files):
// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
or (for `.h` and `.S` files):
/* SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause */
Given the style of the line to be used depends on the extension,
a simple `sed` insert command would not work.
It also skips the file if an existing SPDX line is there,
as well as raising an error if an unexpected SPDX line appears
anywhere else in the file, as well as for unexpected
file extensions.
I double-checked that all currently generated files appear
to be license as expected with:
grep -LRF 'This source code is licensed under both the BSD-style license (found in the' linux/lib/zstd
grep -LRF 'LICENSE file in the root directory of this source tree) and the GPLv2 (found' linux/lib/zstd
but somebody knowledgable on the licensing of the project should
double-check this is the intended case.
Fixes: #3293
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
|
Yeah, all of our files share the same license. We have a test to make sure that they all have the a consistent copyright + license. This looks great! Thanks for the PR @ojeda! I will back port it to the changes I'm making on top of the v1.5.2 release for the next kernel update. |
That is a nice test to have indeed.
My pleasure! After I sent you that email, I thought I could give it a go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
--spdxoption to the freestanding script (and use it from thelinux-kernelMakefile) to prefix files with a line like (for.cfiles):or (for
.hand.Sfiles):Given the style of the line to be used depends on the extension, a simple
sedinsert command would not work.It also skips the file if an existing SPDX line is there, as well as raising an error if an unexpected
SPDX-License-Identifierstring appears anywhere else in the file, as well as for unexpected file extensions.I double-checked that all currently generated files appear to be licensed as expected with:
but somebody knowledgeable on the licensing of the project should double-check this is the intended case.
Fixes: #3293
Signed-off-by: Miguel Ojeda ojeda@kernel.org