Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the wrong check for buffer overrun in UTIL_mergeFileNamesTable #3300

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix the wrong check for buffer overrun in UTIL_mergeFileNamesTable #3300

merged 1 commit into from
Nov 2, 2022

Conversation

yiyuaner
Copy link
Contributor

The index into newTable->fileNames is not checked properly in the assertion.
Notice that the number of elements in newTable->fileNames is newTable->tableSize,

@embg embg merged commit b1182fe into facebook:dev Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yiyuaner @Cyan4973 @embg