[pzstd] Fixes for Windows build #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI is passing now. |
Cyan4973
reviewed
Dec 19, 2022
| // Required for windows, which defines min/max, but we want the std:: version. | ||
|
|
||
| #ifdef min | ||
| #undef min |
There was a problem hiding this comment.
very minor :
I believe you can #undef unconditionally, whether min is already defined or not.
This is explicitly allowed by the standard,
and I believe no compiler warning will be triggered.
Cyan4973
approved these changes
Dec 19, 2022
* Add `Portability.h` to fix min/max issues. * Fix conversion warnings * Assert that windowLog <= 23, which is currently always the case. This could be loosened, but we aren't looking to add new functionality. Fixes on top of PR facebook#3375 by @eli-schwartz, which added Windows CI for contrib & programs.
This was referenced Dec 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portability.hto fix min/max issuesThis could be loosened, but we aren't looking to add new functionality.
Fixes on top of PR #3375 by @eli-schwartz, which added Windows CI for contrib & programs.