Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuzzing with ZSTD_MULTITHREAD #3417

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Fix fuzzing with ZSTD_MULTITHREAD #3417

merged 2 commits into from
Jan 11, 2023

Conversation

danlark1
Copy link
Contributor

At Google we fuzz zstd without ZSTD_MULTITHREAD but we want inputs to be as much as reproducible. It allows us to test new fuzzing methods for our fuzz team internally and have more horsepower to find bugs

At Google we fuzz zstd without ZSTD_MULTITHREAD but we want inputs to be as much as reproducible. It allows us to test new fuzzing methods for our fuzz team internally and have more horsepower to find bugs
Copy link
Contributor

@terrelln terrelln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @danlark1!

@danlark1
Copy link
Contributor Author

danlark1 commented Jan 10, 2023

Don't merge for now, please :)

    case ZSTD_c_nbWorkers :
#ifndef ZSTD_MULTITHREAD
        // Must be zero.
        RETURN_ERROR_IF(value!=0, parameter_unsupported, "not compiled with multithreading");
        return 0;
#else
        FORWARD_IF_ERROR(ZSTD_cParam_clampBounds(param, &value), "");
        CCtxParams->nbWorkers = value;
        return CCtxParams->nbWorkers;
#endif

UPD now should be good, thanks

@terrelln terrelln merged commit ca2ff78 into facebook:dev Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants