Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Custom ASAN/MSAN Poisoning on MinGW Builds #3424

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Disable Custom ASAN/MSAN Poisoning on MinGW Builds #3424

merged 2 commits into from
Jan 17, 2023

Conversation

felixhandte
Copy link
Contributor

Addresses #3240.

@felixhandte
Copy link
Contributor Author

As discussed, I'm not convinced this is a real issue. Hopefully @calvin2021y will respond with more information.

@felixhandte
Don't Even Declare Poisoning Functions if Poisoning is Disabled
d78fbed 
This guarantees that we won't accidentally forget to check the macro somewhere
where we use these functions.
terrelln
terrelln approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@terrelln terrelln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, I'll let you decide whether you want to merge or not

@felixhandte felixhandte merged commit 23a356c into facebook:dev Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrelln terrelln terrelln approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixhandte @terrelln @facebook-github-bot