added c89 build test to CI #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reducing the strict iso |
Cyan4973
force-pushed
the
c89build
branch
3 times, most recently
from
93078f1
to
a079d48
Compare
|
Needs to be rebased |
done |
|
only |
terrelln
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test ensures that
libzstdand thezstdCLI can be compiled withc89/c90compilers,with the additional requirement of
long longtype and variadic macros support.Fixed a few
-pedanticwarnings that appeared in the process.The test initially attempted to compile
tests/tools with the same requirement,but this is a strong requirement, which makes the code more difficult to write at times,
so it feels only appropriate to accept this restriction for
libzstdand thezstdCLI proper.