Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set dictionary ID in ZSTD_initCStream_usingCDict() #511

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Set dictionary ID in ZSTD_initCStream_usingCDict() #511

merged 1 commit into from
Jan 17, 2017

Commits on Jan 15, 2017

  1. Set dictionary ID in ZSTD_initCStream_usingCDict() 

    When porting python-zstandard to use ZSTD_initCStream_usingCDict()
so compression dictionaries could be reused, an automated test
failed due to compressed content changing.

I tracked this down to ZSTD_initCStream_usingCDict() not
setting the dictID field of the ZSTD_CCtx attached to the
ZSTD_CStream instance.

I'm not 100% convinced this is the correct or full solution,
as I'm still seeing one automated test failing with this change.
    @indygreg
    indygreg committed Jan 15, 2017
    Configuration menu
    Copy the full SHA
    7d6f478 View commit details
    Browse the repository at this point in the history