This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Fixed NullPointerException when there is no HeroView on Android. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,15 +116,17 @@ private static int getRoundedCorners(@NonNull CardConfiguration cardConfiguratio | |||
| @Override | |||
| protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) { | |||
| LayoutParams params = (LayoutParams) assetView.getLayoutParams(); | |||
| params.height = LayoutParams.WRAP_CONTENT; | |||
| // Params can return null if the assetView is not yet attached to the screen. | |||
| if (params != null) { | |||
There was a problem hiding this comment.
Good catch. I'd prefer a if (params == null) { return } instead of indenting here, though.
There was a problem hiding this comment.
Sure, doesn't matter much, the important part is that we need to explicitly call into super here.
nlutsenko
force-pushed
the
nlutsenko.android.nohero
branch
from
0f9079f
to
fc58bc8
Compare
|
@nlutsenko updated the pull request. |
nlutsenko
force-pushed
the
nlutsenko.android.nohero
branch
from
fc58bc8
to
c29369b
Compare
|
@nlutsenko updated the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we were always trying to get/set the height of the
assetViewin the HeroView, even though we never add it as a subview.This produced a NullPointerException. Tested with any of the example payloads by removing
heroportion of the payload.Also, as a result - we needed to handle the corner radius case in BodyView (which turns out is handled in ActionsView, but not in BodyView).