This repository has been archived by the owner on Feb 1, 2020. It is now read-only.
Add support for asynchronous allgatherTensor. #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because allgatherTensor is a multi-stage process (allgather the sizes, allgather the data), we
can't easily perform it asynchronously. Instead, we complicated the API a bit to make each step
explicit. That is, instead of allgatherTensor(input, output) the API is now:
local tensordesc = mpi.newTensorDesc(mpi.size())
mpi.allgatherTensorDesc(input, tensordesc)
mpi.resizeTensorFromDesc(output, tensordesc)
local handle = mpi.allgatherTensor(input, output, tensordesc)
mpi.freeTensorDesc(tensordesc)
Note also that resizeTensorFromDesc can result in the storage for the output changing
(in case the provided storage is too small).
This could be improved to handle new/free internally, and to provide a single-function
synchronous version.