This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Use re.MULTILINE instead of re.DOTALL #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure which use cases this change breaks, but I found I need the other mode to also catch trailing newlines when removing rcsids from old C code with this invocation: codemod -m '^.+?RCSID.+?$\n*' ''
ghost
added
the
|
Thanks! A command-line option (with the current behavior as the default) sounds like it might be best. |
|
Hey there! I found that it is more complicated, MULTILINE and DOTALL do different things and can even be combined. Plus there is a comment in the code that says that the multiline suggestor is "hacky and should be rewritten". I can only imagine it to be quite tricky, given the lack of a simple notion what a chunk is. Not sure if you could run this by the original author, at the moment I have no good idea how to do this cleanly and will therefore close this PR for the time being. |
|
OK, that sounds reasonable. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure which use cases this change breaks, but I found I need the
other mode to also catch trailing newlines when removing rcsids from
old C code with this invocation: codemod -m '^.+?RCSID.+?$\n*'
Or maybe we could add a command line option to choose the multiple line mode?