[Italian] "san silvestro" and "notte di san silvestro" examples are failing

[patapizza]

duckling.core=> (load!)
duckling.core=> (run)
...
:it$core: 534 examples, 2 failed.
...

cc @ibobo - can you take a look at this?

[ibobo]

I have no failing examples... checked on my repository with the latest master merged and also on a fresh clone of the main repository

[ibobo]

I found that two rules did the same thing (I restructured that part last night), maybe that's causing the problem on your part. Still I don't understand how my repo can work if your's failing... anyway, will send a new pull request in a few minutes.

[ibobo]

Sorry... no luck... the <time> notte and <time> notte rules need to stay there. Hope you find the culprit.

[patapizza]

Thanks for checking @ibobo.
I still have the issue using a fresh copy of the repo. Might be just my environment.

Someone else can confirm?

[l5t]

Works for me.

Please reopen if not working for you

[bisoldi]

I'm actually getting this failure (see below) using the maven dependency v. 0.4.23.

"not found" "san silvestro"
"not found" "notte di san silvestro"

I'm doing this while trying to call Duckling via Java. I am experiencing other issues as well, which i'll open another ticket for, but wanted to add to this ticket.

The full output is:

SLF4J: A number (37) of logging calls during the initialization phase have been intercepted and are
SLF4J: now being replayed. These are subject to the filtering rules of the underlying logging system.
SLF4J: See also http://www.slf4j.org/codes.html#replay

"not found" "san silvestro"
"not found" "notte di san silvestro"

{:sv$core (:unit :number :ordinal :amount-of-money :time :unit-of-duration :duration :cycle :timezone), :pt$core (:phone-number :number :distance :volume :temperature :time :url :email :timezone :unit :amount-of-money :leven-unit :quantity :ordinal :unit-of-duration :cycle :duration), :ko$core (:phone-number :number :distance :volume :temperature :time :url :email :timezone :cycle :unit-of-duration :unit :duration :amount-of-money :leven-unit :quantity :leven-product :ordinal), :id$core (:unit :number :amount-of-money :ordinal), :nl$core (:number :distance :volume :ordinal), :pl$core (:number :time :unit-of-duration :duration :ordinal :cycle :timezone), :tr$core (:number :ordinal), :nb$core (:unit :number :amount-of-money :time :ordinal :timezone :cycle :unit-of-duration :duration), :my$core (:number), :ru$core (:number :ordinal), :ja$core (:number :temperature :ordinal), :fr$core (:phone-number :number :time :distance :volume :temperature :url :email :timezone :unit :amount-of-money :leven-unit :leven-product :quantity :ordinal :cycle :unit-of-duration :duration), :es$core (:phone-number :number :distance :volume :temperature :time :url :email :timezone :unit :amount-of-money :cycle :unit-of-duration :duration :ordinal), :da$core (:number :time :timezone :ordinal :cycle :unit-of-duration :duration), :zh$core (:number :temperature :time :ordinal :cycle :unit-of-duration :duration), :ar$core (:number :ordinal), :ga$core (:unit :number :amount-of-money :distance :volume :temperature :time), :it$core (:phone-number :number :time :url :email :timezone :ordinal :cycle :unit-of-duration :duration), :de$core (:number :time :ordinal :cycle :unit-of-duration :duration :timezone), :ro$core (:phone-number :number :distance :volume :temperature :time :url :email :timezone :unit :amount-of-money :leven-unit :leven-product :quantity :ordinal :cycle :unit-of-duration), :vi$core (:unit :number :amount-of-money), :uk$core (:number :ordinal), :et$core (:number :ordinal), :en$core (:phone-number :number :distance :volume :temperature :time :url :email :timezone :unit :amount-of-money :leven-unit :quantity :leven-product :ordinal :cycle :unit-of-duration :duration)}

#'duckling.core/c

The relevant Maven snippets:

<repositories>
    <repository>
        <id>clojars</id>
        <name>clojars</name>
        <url>https://clojars.org/repo</url>
    </repository>
</repositories>
<dependencies>
    <dependency>
        <groupId>wit</groupId>
        <artifactId>duckling</artifactId>
        <version>0.4.23</version>
    </dependency>
    <dependency>
        <groupId>org.slf4j</groupId>
        <artifactId>slf4j-log4j12</artifactId>
        <version>1.7.22</version>
    </dependency>
    <dependency>
        <groupId>org.slf4j</groupId>
        <artifactId>slf4j-api</artifactId>
        <version>1.7.22</version>
    </dependency>
    <dependency>
        <groupId>log4j</groupId>
        <artifactId>log4j</artifactId>
        <version>1.2.17</version>
    </dependency>
</dependencies>

My code:

import clojure.lang.Keyword;
import clojure.lang.RT;
import clojure.lang.Symbol;
import clojure.lang.Var;
import java.io.IOException;

public class DucklingService {
    
    public static void main(String[] args) throws IOException, ClassNotFoundException {
        Var require = RT.var("clojure.core", "require");
        Symbol namespace = Symbol.intern("duckling.core");
        Var load = RT.var("duckling.core", "load!");
        Keyword keyword = Keyword.intern("duck");
        Object loadResult = require.invoke(namespace);
        System.out.println(load.invoke() + "\n");
        
        Var test = RT.var("duckling.core", "run");
        Var testResult = (clojure.lang.Var) test.invoke();
        System.out.println(testResult);
        System.out.println("Done");
  }

[FraBle]

@bisoldi: any update on this?

[bisoldi]

@FraBle No update. We implemented Duckling and got it to run, though this issue still existed. I don't think it was a fatal error, so we just left it.