Skip to content
This repository has been archived by the owner on Oct 15, 2019. It is now read-only.

NettyServerConfigBuilder instead of NettyConfigBuilder #121

Closed
reddragon opened this issue Oct 28, 2014 · 5 comments
Closed

NettyServerConfigBuilder instead of NettyConfigBuilder #121

reddragon opened this issue Oct 28, 2014 · 5 comments

Comments

@reddragon
Copy link

There is a small mistake on the README.md

    // Create the server transport
    final NettyServerTransport server = new NettyServerTransport(serverDef,
                                                                 new NettyConfigBuilder(),
                                                                 new DefaultChannelGroup(),
                                                                 new HashedWheelTimer());

replace by

    // Create the server transport
    final NettyServerTransport server = new NettyServerTransport(serverDef,
                                                                 new NettyServerConfigBuilder(),
                                                                 new DefaultChannelGroup(),
                                                                 new HashedWheelTimer());
@alandau
Copy link
Contributor

alandau commented Oct 28, 2014

I would accept a pull request :-)

@reddragon
Copy link
Author

Sure, will do :)

@andrewcox
Copy link
Contributor

Are you synced to old sources? This is already renamed.

@andrewcox
Copy link
Contributor

Oh duh, readme :)

@andrewcox
Copy link
Contributor

42774bf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants