Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

Environment.setBackground gives an error #825

Open
talwaserman opened this issue Aug 14, 2020 · 0 comments
Open

Environment.setBackground gives an error #825

talwaserman opened this issue Aug 14, 2020 · 0 comments

Comments

@talwaserman
Copy link

Description

Environment.setBackground gives an error
and this is what is instructed to be used in the docs located in this page
https://facebook.github.io/react-360/docs/photos-and-videos.html

Environment.setBackground( asset('path/to/image.jpg'), {format: '2D'}, /* one of the formats mentioned above */ );

Expected behavior

as i understand you should update the docs to instruct the following

Environment.setBackgroundImage( './static_assets/360_world.jpg', {format: '2D'} );

Actual behavior

gives an error

Reproduction

just following the docs.

Solution

as described, use the following:

Environment.setBackgroundImage( './static_assets/360_world.jpg', {format: '2D'} );

What needs to be done to address this issue? Ideally, provide a pull request with a fix.
please update your doc file in the following address, so others will not have the same issue, thanks
https://facebook.github.io/react-360/docs/photos-and-videos.html

Additional Information

  • 'react-360' package version: react-360@1.1.0
  • 'react-360-web' package version: react-360-web@1.1.0
  • Operating System: MacOS
  • Browser: Chrome
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant