Skip to content
This repository has been archived by the owner on Oct 11, 2018. It is now read-only.

Susceptible to changing NODE_ENV #13

Closed
ssorallen opened this issue May 12, 2016 · 0 comments
Closed

Susceptible to changing NODE_ENV #13

ssorallen opened this issue May 12, 2016 · 0 comments

Comments

@ssorallen
Copy link

ssorallen commented May 12, 2016

Because this currently loads the development version of React, the outcomes of its NODE_ENV === 'production' checks will change based on the changing value of NODE_ENV.

Atom 1.8 updates Atom's ENV on new invocations from the command line, which often means NODE_ENV will change values on subsequent invocations. Changing from Atom's default NODE_ENV === production to the common case of an undefined NODE_ENV in users' shell environment can lead to crashes like was reported in Nuclide: facebookarchive/nuclide#463

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants