[recoil][devtools] Release snapshots #1006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@drarmstr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@davidmccabe merged this pull request in 6e265c0. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Let the Dev Tools retain snapshots that it's using. Pull Request resolved: facebookexperimental/Recoil#1006 Test Plan: Use React Playground and verify that: * The warning about unretained snapshots is eliminated. * Retained snapshots don't accumulate beyond the number it's supposed to retain. Reviewed By: maxijb Differential Revision: D28340893 Pulled By: davidmccabe fbshipit-source-id: e562b2917dde1e3f6ad9db49a67015a33e4eb0cf
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Let the Dev Tools retain snapshots that it's using. Pull Request resolved: facebookexperimental/Recoil#1006 Test Plan: Use React Playground and verify that: * The warning about unretained snapshots is eliminated. * Retained snapshots don't accumulate beyond the number it's supposed to retain. Reviewed By: maxijb Differential Revision: D28340893 Pulled By: davidmccabe fbshipit-source-id: e562b2917dde1e3f6ad9db49a67015a33e4eb0cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the Dev Tools retain snapshots that it's using.
Test plan:
Use React Playground and verify that: