Provide new value to onSet() handler when triggered by async default #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D28850148 |
Summary: When an atom effect's `onSet()` handler is triggered due to having a default which is an async `Promise` that resolves the handler should be able to get the proper new value instead of a `DefaultValue` placeholder. This addresses customer-reported issue facebookexperimental#1050 Differential Revision: D28850148 fbshipit-source-id: 0f19d2179e7f3d522887550af32b87247f979f26
drarmstr
force-pushed
the
export-D28850148
branch
from
731186a
to
57a008c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D28850148 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When an atom effect's
onSet()handler is triggered due to having a default which is an asyncPromisethat resolves the handler should be able to get the proper new value instead of aDefaultValueplaceholder.This addresses customer-reported issue #1050
Differential Revision: D28850148