Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript for getCallback() in selectorFamily() #1060

Closed

Conversation

drarmstr
Copy link
Contributor

@drarmstr drarmstr commented Jun 4, 2021

Summary:
Add getCallback() to the selectorFamily() interface consistent with selector().

Fixes #989

Differential Revision: D28904928

Summary:
Add `getCallback()` to the `selectorFamily()` interface consistent with `selector()`.

Fixes facebookexperimental#989

Differential Revision: D28904928

fbshipit-source-id: 589a63826c92a53f062d69853de84182cf404028
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jun 4, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28904928

@drarmstr drarmstr self-assigned this Jun 4, 2021
@drarmstr drarmstr added bug Something isn't working TypeScript / Flow labels Jun 4, 2021
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 00264f4.

@drarmstr drarmstr deleted the export-D28904928 branch September 21, 2021 18:24
AlexGuz23 pushed a commit to AlexGuz23/Recoil that referenced this pull request Nov 3, 2022
Summary:
Pull Request resolved: facebookexperimental/Recoil#1060

Add `getCallback()` to the `selectorFamily()` interface consistent with `selector()`.

Fixes #989

Reviewed By: davidmccabe

Differential Revision: D28904928

fbshipit-source-id: bf03927e6a920b623849c1767231323f2a7f8b70
snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
Summary:
Pull Request resolved: facebookexperimental/Recoil#1060

Add `getCallback()` to the `selectorFamily()` interface consistent with `selector()`.

Fixes #989

Reviewed By: davidmccabe

Differential Revision: D28904928

fbshipit-source-id: bf03927e6a920b623849c1767231323f2a7f8b70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged TypeScript / Flow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants