enable dangerouslyAllowMutability in waitFor utils #1096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D29461447 |
Summary: Pull Request resolved: facebookexperimental#1091 todo Differential Revision: D29449437 fbshipit-source-id: 21f7156ce74520080f882c7f4bdb034764754885
…tal#1096) Summary: Pull Request resolved: facebookexperimental#1096 Fixes facebookexperimental#1074 Adds `dangerouslyAllowMutability` by default to the waitFor helpers to unblock users that need that prop enabled in the returned selectors. Differential Revision: D29461447 fbshipit-source-id: cde6c44299ac56c9bb0066b2c845f333820e62df
|
This pull request was exported from Phabricator. Differential Revision: D29461447 |
csantos42
force-pushed
the
export-D29461447
branch
2 times, most recently
from
aeaff97
to
14a1e0d
Compare
|
This pull request has been merged in e717737. |
csantos42
pushed a commit
to csantos42/Recoil
that referenced
this pull request
Jul 29, 2021
Summary: Adds short description of change made in PR facebookexperimental#1096 which fixed issue facebookexperimental#1074 Differential Revision: D29980856 fbshipit-source-id: b46d7588125ada69175faff9b9a0b562f4c991c6
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1096 Fixes facebookexperimental/Recoil#1074 Adds `dangerouslyAllowMutability` by default to the waitFor helpers to unblock users that need that prop enabled in the returned selectors. Reviewed By: drarmstr Differential Revision: D29461447 fbshipit-source-id: 176fe501f1e663ed3dbe024443646d5c51f8a033
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1096 Fixes facebookexperimental/Recoil#1074 Adds `dangerouslyAllowMutability` by default to the waitFor helpers to unblock users that need that prop enabled in the returned selectors. Reviewed By: drarmstr Differential Revision: D29461447 fbshipit-source-id: 176fe501f1e663ed3dbe024443646d5c51f8a033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1074
Adds
dangerouslyAllowMutabilityby default to the waitFor helpers to unblock users that need that prop enabled in the returned selectors.Differential Revision: D29461447