Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore package-lock.json #1374

Closed
wants to merge 2 commits into from

Conversation

drarmstr
Copy link
Contributor

@drarmstr drarmstr commented Nov 4, 2021

Summary:
Ignore NPM's package-lock.json for GitHub source repository since we are using Yarn's yarn.lock.

https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files

Differential Revision: D32163952

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Nov 4, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32163952

drarmstr added a commit to drarmstr/Recoil that referenced this pull request Nov 5, 2021
Summary:
Pull Request resolved: facebookexperimental#1374

Ignore NPM's `package-lock.json` for GitHub source repository since we are using Yarn's `yarn.lock`.

https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files

Differential Revision: D32163952

fbshipit-source-id: 5facb0be836a22ce34c1777faefef217f174587d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32163952

@drarmstr drarmstr self-assigned this Nov 6, 2021
Summary: When switching between `docs` and `main` branches on a local checkout and building the docs a `/docs` directory can be left behind which has lots of lint failures.  Suppresses this for `yarn lint` to avoid noise.

Differential Revision: D32199533

fbshipit-source-id: 47fe00729e6f52ecfed0e826703d84b21fd70ecd
Summary:
Pull Request resolved: facebookexperimental#1374

Ignore NPM's `package-lock.json` for GitHub source repository since we are using Yarn's `yarn.lock`.

https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files

Reviewed By: bsouthga

Differential Revision: D32163952

fbshipit-source-id: 95b97a57cd6d2a015f7e98a9c803679767eb20c4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D32163952

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in fcfa53f.

@drarmstr drarmstr deleted the export-D32163952 branch November 18, 2021 01:43
AlexGuz23 pushed a commit to AlexGuz23/Recoil that referenced this pull request Nov 3, 2022
Summary:
Pull Request resolved: facebookexperimental/Recoil#1374

Ignore NPM's `package-lock.json` for GitHub source repository since we are using Yarn's `yarn.lock`.

https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files

Reviewed By: bsouthga

Differential Revision: D32163952

fbshipit-source-id: dbbd3195d5e6e1e26b218e8cb11dd21484568634
snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
Summary:
Pull Request resolved: facebookexperimental/Recoil#1374

Ignore NPM's `package-lock.json` for GitHub source repository since we are using Yarn's `yarn.lock`.

https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files

Reviewed By: bsouthga

Differential Revision: D32163952

fbshipit-source-id: dbbd3195d5e6e1e26b218e8cb11dd21484568634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build / infra CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants