New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore package-lock.json #1374
Closed
Closed
Ignore package-lock.json #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
labels
Nov 4, 2021
This pull request was exported from Phabricator. Differential Revision: D32163952 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Nov 5, 2021
Summary: Pull Request resolved: facebookexperimental#1374 Ignore NPM's `package-lock.json` for GitHub source repository since we are using Yarn's `yarn.lock`. https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files Differential Revision: D32163952 fbshipit-source-id: 5facb0be836a22ce34c1777faefef217f174587d
drarmstr
force-pushed
the
export-D32163952
branch
from
November 5, 2021 22:12
4e71c83
to
69fe548
Compare
This pull request was exported from Phabricator. Differential Revision: D32163952 |
Summary: When switching between `docs` and `main` branches on a local checkout and building the docs a `/docs` directory can be left behind which has lots of lint failures. Suppresses this for `yarn lint` to avoid noise. Differential Revision: D32199533 fbshipit-source-id: 47fe00729e6f52ecfed0e826703d84b21fd70ecd
Summary: Pull Request resolved: facebookexperimental#1374 Ignore NPM's `package-lock.json` for GitHub source repository since we are using Yarn's `yarn.lock`. https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files Reviewed By: bsouthga Differential Revision: D32163952 fbshipit-source-id: 95b97a57cd6d2a015f7e98a9c803679767eb20c4
drarmstr
force-pushed
the
export-D32163952
branch
from
November 9, 2021 23:56
69fe548
to
5a81c50
Compare
This pull request was exported from Phabricator. Differential Revision: D32163952 |
This pull request has been merged in fcfa53f. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1374 Ignore NPM's `package-lock.json` for GitHub source repository since we are using Yarn's `yarn.lock`. https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files Reviewed By: bsouthga Differential Revision: D32163952 fbshipit-source-id: dbbd3195d5e6e1e26b218e8cb11dd21484568634
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1374 Ignore NPM's `package-lock.json` for GitHub source repository since we are using Yarn's `yarn.lock`. https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files Reviewed By: bsouthga Differential Revision: D32163952 fbshipit-source-id: dbbd3195d5e6e1e26b218e8cb11dd21484568634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build / infra
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Ignore NPM's
package-lock.json
for GitHub source repository since we are using Yarn'syarn.lock
.https://stackoverflow.com/questions/44552348/should-i-commit-yarn-lock-and-package-lock-json-files
Differential Revision: D32163952