Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] recommends adding 'useRecoilCallback' to eslint config #203

Merged
merged 1 commit into from Jun 6, 2020
Merged

[docs] recommends adding 'useRecoilCallback' to eslint config #203

merged 1 commit into from Jun 6, 2020

Conversation

acutmore
Copy link

Addresses #180

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2020
@acutmore acutmore mentioned this pull request May 30, 2020
Closed
@drarmstr drarmstr added the documentation Improvements or additions to documentation label May 31, 2020
@drarmstr drarmstr linked an issue May 31, 2020 that may be closed by this pull request
Add lint rule for useRecoilCallback deps array #180
Closed
@drarmstr drarmstr self-requested a review May 31, 2020 00:19
drarmstr
drarmstr reviewed Jun 5, 2020
View reviewed changes
Copy link
Contributor

@drarmstr drarmstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on validating this approach...

docs/docs/introduction/installation.md
}
```

It is recommended to add [useRecoilCallback](docs/api-reference/core/useRecoilCallback) to the list of `additionalHooks`. With this change ESLint will now warns when the dependencies passed to `useRecoilCallback` are specified incorrectly and suggests a fix.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "warns"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a note that the format of additionalHooks is a regex.

@drarmstr drarmstr merged commit 623ee9d into facebookexperimental:docs Jun 6, 2020
@drarmstr
Copy link
Contributor

drarmstr commented Jun 6, 2020

#261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drarmstr drarmstr drarmstr left review comments

@alexandrzavalii alexandrzavalii alexandrzavalii approved these changes

@renatobenks renatobenks renatobenks approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lint rule for useRecoilCallback deps array
5 participants
@acutmore @drarmstr @alexandrzavalii @renatobenks @facebook-github-bot