Fix effects to initialize when unrelated atoms are updated #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Multiple customers reported a corner case (see [facebookexperimental#774](facebookexperimental#774)) that atom effects would not initialize atom values if the atom was initialized due to an async action that also updated unrelated atom values. It looks like in those situations the `nextTree` was started, but the effects were only mutating `currentTree` during initialization. Differential Revision: D25237913 fbshipit-source-id: 783cc039e71b1f84ff9916b8a3f1167d0adca001
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D25237913 |
|
This pull request has been merged in 47f0651. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#775 Multiple customers reported a corner case (see [#774](facebookexperimental/Recoil#774)) that atom effects would not initialize atom values if the atom was initialized due to an async action that also updated unrelated atom values. It looks like in those situations the `nextTree` was started, but the effects were only mutating `currentTree` during initialization. Reviewed By: davidmccabe Differential Revision: D25237913 fbshipit-source-id: 9d01392fd910163171ffdfb489c646eee6c5cd4d
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#775 Multiple customers reported a corner case (see [#774](facebookexperimental/Recoil#774)) that atom effects would not initialize atom values if the atom was initialized due to an async action that also updated unrelated atom values. It looks like in those situations the `nextTree` was started, but the effects were only mutating `currentTree` during initialization. Reviewed By: davidmccabe Differential Revision: D25237913 fbshipit-source-id: 9d01392fd910163171ffdfb489c646eee6c5cd4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Multiple customers reported a corner case (see #774) that atom effects would not initialize atom values if the atom was initialized due to an async action that also updated unrelated atom values. It looks like in those situations the
nextTreewas started, but the effects were only mutatingcurrentTreeduring initialization.Differential Revision: D25237913