feat: set Robyn::dt_prophet_holidays as default dt_holidays param

facebookexperimental · Sep 1, 2022 · 01610a4 · 01610a4
1 parent a07415d
commit 01610a4
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/R/R/data.R b/R/R/data.R
@@ -26,7 +26,7 @@
 #' @return Dataframe. Contains simulated dummy dataset to test and run demo.
 "dt_simulated_weekly"
 
-# dt_input <- fread('data/de_simulated_data.csv')
+# dt_input <- read.csv('data/de_simulated_data.csv')
 # save(dt_input, file = "data/dt_input.RData", version = 2)
 # dt_simulated_weekly <- as_tibble(dt_simulated_weekly)
 # save(dt_simulated_weekly, file = "data/dt_simulated_weekly.RData", version = 2)

diff --git a/R/R/inputs.R b/R/R/inputs.R
@@ -148,7 +148,7 @@
 #' Class: \code{robyn_inputs}.
 #' @export
 robyn_inputs <- function(dt_input = NULL,
-                         dt_holidays = NULL,
+                         dt_holidays = Robyn::dt_prophet_holidays,
                          date_var = "auto",
                          dep_var = NULL,
                          dep_var_type = NULL,

diff --git a/R/R/refresh.R b/R/R/refresh.R
@@ -73,7 +73,7 @@
 #' Robyn <- robyn_refresh(
 #'   json_file = json_file,
 #'   dt_input = dt_simulated_weekly,
-#'   dt_holidays = dt_prophet_holidays,
+#'   dt_holidays = Robyn::dt_prophet_holidays,
 #'   refresh_steps = 13,
 #'   refresh_mode = "auto",
 #'   refresh_iters = 200,
@@ -85,7 +85,7 @@
 #' Robyn <- robyn_refresh(
 #'   json_file = json_file2,
 #'   dt_input = dt_simulated_weekly,
-#'   dt_holidays = dt_prophet_holidays,
+#'   dt_holidays = Robyn::dt_prophet_holidays,
 #'   refresh_steps = 4,
 #'   refresh_mode = "manual",
 #'   refresh_iters = 200,
@@ -97,7 +97,7 @@
 robyn_refresh <- function(json_file = NULL,
                           robyn_object = NULL,
                           dt_input = NULL,
-                          dt_holidays = NULL,
+                          dt_holidays = Robyn::dt_prophet_holidays,
                           plot_folder_sub = NULL,
                           refresh_steps = 4,
                           refresh_mode = "manual",

diff --git a/R/man/robyn_outputs.Rd b/R/man/robyn_outputs.Rd