fix: pick refresh model by error_score correctly #674

facebookexperimental · Apr 12, 2023 · 4f3289d · 4f3289d
1 parent d51169d
commit 4f3289d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/R/R/refresh.R b/R/R/refresh.R
@@ -294,9 +294,9 @@ robyn_refresh <- function(json_file = NULL,
       ...
     )
 
-    ## Select winner model for current refresh
+    ## Select winner model for current refresh (the higher error_score the better)
     OutputCollectRF$resultHypParam <- OutputCollectRF$resultHypParam %>%
-      arrange(.data$solID, desc(.data$error_score)) %>%
+      arrange(desc(.data$error_score)) %>%
       select(.data$solID, everything()) %>%
       ungroup()
     bestMod <- OutputCollectRF$resultHypParam$solID[1]