Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperparameters out of bounds #1003

Open
malaman5 opened this issue Jun 20, 2024 · 0 comments
Open

Hyperparameters out of bounds #1003

malaman5 opened this issue Jun 20, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@malaman5
Copy link

Project Robyn

Describe issue

Im getting this error when running robyn_inputs()

Error in check_hyper_limits(hyperparameters_ordered, "thetas") :
pinterest_spend_thetas's hyperparameter must have upper bound <1

The hyperparameter upper bound for is currently set to <1 in the json file:
"pinterest_spend_alphas": [
0.5,
3
],
"pinterest_spend_gammas": [
0.3,
1
],
"pinterest_spend_thetas": [
0.1,
0.4
],

Provide reproducible example

input_collect <- robyn_inputs(
dt_holidays = dt_prophet_holidays,
dt_input = dataset,
json_file = parameters_file
)

The hyperparameters have been included in the parameters_file as a JSON just like other networks. When checking the input_collect object, the hyperparameters DO NOT include the pinterest hyperparameters. Not sure if it's not included due to the error or the error comes because the hyperparameters are not correctly declared. The pinterest hyperparameters have the very same structure as any other network which is parsed completely fine.

Environment & Robyn version

  • ‘3.11.0’ (also occurred with 3.10.3)
  • "R version 4.3.2 (2023-10-31)"
@laresbernardo laresbernardo self-assigned this Jul 1, 2024
@laresbernardo laresbernardo added the bug Something isn't working label Jul 3, 2024
laresbernardo added a commit that referenced this issue Jul 24, 2024
…ns (#1013)

* fix: skip other hyperparameters from old flow to replace exposure hyps with spend hyps #1003
* feat: new robyn_immcarr() + export more functions
* fix: missing rbind line added
* fix: group warning and repeated vals
* recode: show Immediate on the left and Carryover on the right in op plot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants