-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The presence of some zero coefficients might cause robyn_allocator to report all coefficients are zero #345
Comments
Feel free to re-open if this particular error or issue persists when updating to 3.6.2 @harell |
This is still an issue. The allocator works when all the channel boundaries are between 0.5 and 2 (on all the channels). But once the boundaries are between 0.9 and 1.1, the allocator prompts the '0' coefficients message. |
@harell could you run |
What commit to master do you think will resolve it? I tried running the code with tag v3.6.2. The problem presists. |
@kyletgoldberg I still have this issue. Three channels with 0-coefficients are included in the allocator, and three channels with non zero coefficients (our most contributing channel as well as smaller channels) are excluded. |
@harell running |
@laresbernardo I'm debugging rows 161-169 (the code section you linked): The first line Next, Then, Lmk if you need more info. Thank you! |
Hi @johnscherrer there was def an error in the message displayed. I fixed it earlier today. Now, let me see if I understand what's happening in your case for the last part: it's filtering non 0-coef and leaving some 0-coef variables in |
@laresbernardo correct |
The allocator message reports the zero coefficients now Before: Using Robyn 3.6.2 I get Now: Using commit 990aa8f I get |
@harell thanks for confirming. Is it fixed for your case then? @johnscherrer if the error persists, can you help me debug what's wrong with your case? Can you check the sortings? The selection should be fixed now and I think you shouldn't have problems anymore but you say you do. Do you have a reproducible example? I suggest you try running |
@laresbernardo The error persists for me, but think I found the error source for my case. Will try to explain what goes on when debugging lines 160-173:
Example of what happens in my case - if: The same method is used at line 173: Please let me know if this makes sense from your end. Thanks |
You're right. It was the mediaSpendSorted that wasn't sorted alphabetically in my case, because Now the issue is resolved. Thanks! |
That's great!! So fixing this issue right-away |
Please, can you run |
Got the error msg |
Ah sorry, this should work then: |
Getting this error now when running |
That's an error in the |
Yes, now the budget allocator picked out the correct channels, without changing variable name!! |
Ok, that's good news! So the allocator is fixed but you seem to have problems printing the results when running |
|
Project Robyn
Describe issue
Hey Team
1st iteration:
I am running Robyn 3.6.1 and failing to produce meaningful allocation.
When I extract the coefficients of a Robyn model named 1_237_4 from
Robyn::robyn_outputs
output, then I see that onlycinema_spend
andprint_spend
are zero (see attached table).When I run
Robyn::robyn_allocator
employing model 1_237_4, then I get the following message, saying that all of my coefficients are zero.Why does
Robyn::robyn_allocator
claim that all coefficients of the selected model are zero while the returning object fromRobyn::robyn_outputs
shows otherwise?2nd iteration:
In this iteration, I hypothesise that the presents of zero coefficients lead to the above discrptency.
To test that I:
cinema_spend
andprint_spend
from paid_media_vars (the variable with zero coefficient in the first iteration);Robyn::robyn_allocator
This time,
Robyn::robyn_allocator
produces meaningful allocation with the following messageTherefore, it seems the presence of some zero chaffinches led
Robyn::robyn_allocator
to report all coefficients are zero.Provide dummy data & model configuration
See the above experiment
Environment & Robyn version
The text was updated successfully, but these errors were encountered: