-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo example with weibull adstock failes with error: "'from' must be a finite number"
#353
Comments
Hey there - thanks for flagging this issue, I was able to replicate this and created a branch with a fix for the bug. Could you test the branch on your end and make sure you are getting the expected results and everything is working for you? Thank you! https://github.com/facebookexperimental/Robyn/tree/weibull_testfix |
FYI: to install that version, simply run |
Thank you for so fast hotfix! I have tested weibull_testfix branch, training with weibull adstock starts and seems to work, but I am getting enormous amount of warnings now:
Is it ok and is it possible to suppress them somehow? |
Can you check if you have doRNG (>= 1.8.2)? Run Based on this ticket |
Yes, |
And I still got error robyn_run works correctly
after that I am trying to run robyn_outputs:
and got such stack trace:
It seems to me that problem could be in such strings:
I removed |
Thanks for taking a look at that - that was the problematic condition in the original part, so it should be okay to remove in the rest. I'll work on updating it today. |
Just pushed the fix into main, thanks again for flagging this and working with us to get it solved! #355 |
@kyletgoldberg if this is in main do I need to run this |
@jsatani-tonal, R couldn't execute |
Yes! Makes sense. That’s because that was the branch were we fixed this issue, but now it’s been merged into master. So thanks for confirming @mast4461 |
Project Robyn
Describe issue
Hi! Thank you for a great library!
I faced some problem while using Robyn and can't solve it by myself.
I am trying to run demo example with
adstock = "weibull_cdf"
and getting such error:The thing is that with
adstock = "geometric"
everything works fine and I managed to fit model and obtain results. But with weibull_cdf I got this strange error. I tried to setcores = 1
, but that didn't help. Full stdout/stderr:Provide dummy data & model configuration
I am trying to do robyn_run with data from demo example and my configuration is absolutely the same as in demo.R except for adstock (and hyperparameters list was changed to match weibull parameters):
Environment & Robyn version
packageVersion("Robyn")
returns 3.6.1sessionInfo()
returns:The text was updated successfully, but these errors were encountered: