Weibull testfix #355
Merged
Weibull testfix #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug where we where take rolling window twice
fix bug where we were taking the window length for weibull adstocks twice causing NA values
|
LGTM. Ready to merge! @kyletgoldberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Robyn
Fix a bug where we were taking the rolling window length for weibull adstocks twice resulting in NA values breaking the model process. relevant issue - #353
Fixes # (issue)
Type of change
bug-fix
How Has This Been Tested?
used demo.R to test functionality of all functions with both weibull adstocks