Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README - cross validation #393

Closed
giorgossideris opened this issue May 25, 2022 · 2 comments
Closed

README - cross validation #393

giorgossideris opened this issue May 25, 2022 · 2 comments
Assignees
@laresbernardo
Labels
documentation Improvements or additions to documentation

Comments

@giorgossideris
Copy link

Project Robyn

Describe issue

The README.md file mentions Ridge regression with cross validation, although in this issue is described that no test-train validation is performed, for the model selection. So, which is the case? and should README be updated?
@laresbernardo laresbernardo self-assigned this May 25, 2022
@laresbernardo
Copy link
Collaborator

Hi! Thanks for catching this incongruity in the documentation. We did use cross-validation until February 2022, when we changed the lambda selection to be part of the hyperparameters. Will update now...

@laresbernardo laresbernardo added the documentation Improvements or additions to documentation label May 25, 2022
laresbernardo added a commit that referenced this issue May 25, 2022
@laresbernardo
docs: update deprecated technique incongruence #393
cff3f6d
@Leonelsentana
Copy link
Contributor

Updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laresbernardo laresbernardo

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laresbernardo @giorgossideris @Leonelsentana