Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh picks a Best Model that is not Plotted #428

Closed
Tsurty opened this issue Jul 14, 2022 · 1 comment
Closed

Refresh picks a Best Model that is not Plotted #428

Tsurty opened this issue Jul 14, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Tsurty
Copy link

Tsurty commented Jul 14, 2022

Project Robyn

Describe issue

image

As shown above, after a model refresh with the following code

Robyn <- robyn_refresh(
  robyn_object = robyn_object
  , dt_input = dataset
  , dt_holidays = dt_prophet_holidays
  , refresh_steps = 15
  , refresh_mode = "auto"
  , refresh_iters = 2000
  , refresh_trials = 3
  , clusters = TRUE
)

I got that model 3_249_1 was picked as the best but that was not plotted in the folder
image

However, when doing the budget allocator, it came out from that Model Id.
I guess it has to do with the clusters probably as it was put in Cluster 2 but it was not the Top Model and hence 3_241_5 came out of the cluster.

I believe it doesn't really make sense for refresh to work like this at all and there should be a check in place to avoid such things and eventually select the top model in the same cluster.

@Tsurty
Copy link
Author

Tsurty commented Jul 26, 2022

Hello @laresbernardo thanks for info, you can close it in the meantime as in the end we just picked the model we needed out of the CSV and put it in our custom dashboards. Looking forward to the big changes then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants