-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jde 20211209 general and troubleshoot #236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added weibull_pdf as option into adstock_weibull() and adapted all related functions - improved documentation and readme
deploy weibull_pdf function with lagged effect
Add seed for reproducible results
- to overcome native palette's level limit. new max.24
Gufeng v3.3.2 dev
Gufeng v3.4.3 dev
Gufeng v3.4.4 dev
- fix robyn_refresh bug when input data using read.csv - fix plan(multicore(workers = ...)) bug - sort data by datet - add plot_folder_sub to allow custom folder for results - add check_robyn_object function - fix calibration output bug in robyn_input
Error message: >>> Plotting 17 Pareto optimum models... Error in `[.data.table`(dt_transformSpend, , `:=`((InputCollect$organic_vars), (run_robyn_mmm.R#209): LHS of := isn't column names ('character') or positions ('integer' or 'numeric')
Fix error message when no organic vars were provided
This change improves multi-core performance of robyn_run() My test run on 200 iterations and 4 cores shown 9.5 sec improvement (0.71 -> 0.55 min) Tested on Ubuntu 20.04 / VirtualBox under Win10 host.
Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.5.5 to 3.6.2. - [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases) - [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG) - [Commits](algolia/algoliasearch-helper-js@3.5.5...3.6.2) --- updated-dependencies: - dependency-name: algoliasearch-helper dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
ggplot gets stuck when process is forked This behaviour is reproducible on MacOS only. It works fine on Windows and Linux.
- Multi-core plotting Pareto optimum models - Replace doFuture by doParallel with increased performance
…yarn/website/algoliasearch-helper-3.6.2 Bump algoliasearch-helper from 3.5.5 to 3.6.2 in /website
…into jde_20211209_general_and_troubleshoot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Robyn
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist: