Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jde 20211209 general and troubleshoot #236

Merged
merged 46 commits into from
Dec 9, 2021

Conversation

jeffedwards
Copy link
Contributor

Project Robyn

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

Checklist:

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes.
  • Make sure your code lints.

gufengzhou and others added 30 commits October 12, 2021 21:15
- added weibull_pdf as option into adstock_weibull() and adapted all related functions
- improved documentation and readme
deploy weibull_pdf function with lagged effect
- to overcome native palette's level limit. new max.24
- fix robyn_refresh bug when input data using read.csv
- fix plan(multicore(workers = ...)) bug
- sort data by datet
- add plot_folder_sub to allow custom folder for results
- add check_robyn_object function
- fix calibration output bug in robyn_input
andrey-legayev and others added 16 commits November 18, 2021 18:27
Error message:
>>> Plotting 17 Pareto optimum models...
Error in `[.data.table`(dt_transformSpend, , `:=`((InputCollect$organic_vars),  (run_robyn_mmm.R#209): LHS of := isn't column names ('character') or positions ('integer' or 'numeric')
Fix error message when no organic vars were provided
This change improves multi-core performance of robyn_run()

My test run on 200 iterations and 4 cores shown 9.5 sec improvement (0.71 -> 0.55 min)
Tested on Ubuntu 20.04 / VirtualBox under Win10 host.
Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.5.5 to 3.6.2.
- [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases)
- [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG)
- [Commits](algolia/algoliasearch-helper-js@3.5.5...3.6.2)

---
updated-dependencies:
- dependency-name: algoliasearch-helper
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
ggplot gets stuck when process is forked
This behaviour is reproducible on MacOS only.
It works fine on Windows and Linux.
- Multi-core plotting Pareto optimum models
- Replace doFuture by doParallel with increased performance
…yarn/website/algoliasearch-helper-3.6.2

Bump algoliasearch-helper from 3.5.5 to 3.6.2 in /website
…into jde_20211209_general_and_troubleshoot
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2021
@jeffedwards jeffedwards merged commit 5e8793b into fix Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants