Skip to content

Commit

Permalink
kill openNSA builder
Browse files Browse the repository at this point in the history
Summary:
X-link: facebook/fb303#38

As titled, kill open NSA buidler from sandcastle getdeps

Reviewed By: shri-khare

Differential Revision: D47541677

fbshipit-source-id: 4621150a8accd04a9c8bef77b3d0cdaf9b5c3d0a
  • Loading branch information
srikrishnagopu authored and facebook-github-bot committed Jul 28, 2023
1 parent 28d5cae commit ff6df28
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 24 deletions.
20 changes: 0 additions & 20 deletions build/fbcode_builder/getdeps/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -1125,26 +1125,6 @@ def build(self, install_dirs, reconfigure: bool) -> None:
shutil.copytree(self.src_dir, self.inst_dir)


class OpenNSABuilder(NopBuilder):
# OpenNSA libraries are stored with git LFS. As a result, fetcher fetches
# LFS pointers and not the contents. Use git-lfs to pull the real contents
# before copying to install dir using NoopBuilder.
# In future, if more builders require git-lfs, we would consider installing
# git-lfs as part of the sandcastle infra as against repeating similar
# logic for each builder that requires git-lfs.
def __init__(self, build_opts, ctx, manifest, src_dir, inst_dir) -> None:
super(OpenNSABuilder, self).__init__(
build_opts, ctx, manifest, src_dir, inst_dir
)

def build(self, install_dirs, reconfigure: bool) -> None:
env = self._compute_env(install_dirs)
self._run_cmd(["git", "lfs", "install", "--local"], cwd=self.src_dir, env=env)
self._run_cmd(["git", "lfs", "pull"], cwd=self.src_dir, env=env)

super(OpenNSABuilder, self).build(install_dirs, reconfigure)


class SqliteBuilder(BuilderBase):
def __init__(self, build_opts, ctx, manifest, src_dir, build_dir, inst_dir) -> None:
super(SqliteBuilder, self).__init__(
Expand Down
4 changes: 0 additions & 4 deletions build/fbcode_builder/getdeps/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
MakeBuilder,
NinjaBootstrap,
NopBuilder,
OpenNSABuilder,
OpenSSLBuilder,
SqliteBuilder,
)
Expand Down Expand Up @@ -581,9 +580,6 @@ def create_builder( # noqa:C901
build_options, ctx, src_dir, build_dir, inst_dir, loader
)

if builder == "OpenNSA":
return OpenNSABuilder(build_options, ctx, self, src_dir, inst_dir)

raise KeyError("project %s has no known builder" % (self.name))

def create_prepare_builders(
Expand Down

0 comments on commit ff6df28

Please sign in to comment.