Add github build actions #107
Conversation
facebook-github-bot
added
the
CLA Signed
amyreese
force-pushed
the
jreese-patch-1
branch
from
bc3641e
to
31bf07e
Compare
| @@ -1,19 +1,19 @@ | |||
| venv: | |||
| python3 -m venv .venv | |||
| python -m venv .venv | |||
There was a problem hiding this comment.
PYTHON ?= python at the top
then
$(PYTHON) elsewhere
| python3 -m pip install -Ur requirements.txt | ||
| python3 -m pip install -Ur requirements-dev.txt | ||
| python -m pip install -Ur requirements.txt | ||
| python -m pip install -Ur requirements-dev.txt | ||
|
|
||
| dev: venv | ||
| source .venv/bin/activate && make setup |
There was a problem hiding this comment.
PYTHON=.venv/bin/python make setup
.venv/bin/python setup.py develop
?
.github/workflows/build.yml
Outdated
| - name: Coverage | ||
| continue-on-error: true | ||
| run: | | ||
| coveralls |
There was a problem hiding this comment.
Is this going to update the same location we had with travis?
| run: | | ||
| python -m pip install --upgrade pip | ||
| make setup | ||
| pip install -U . |
There was a problem hiding this comment.
We shouldn't need the install step if we use PYTHON=.venv/bin/python make test, etc... up to you
There was a problem hiding this comment.
I played with this last night, venv on Windows puts the binaries in a different spot. What you have is fine.
amyreese
force-pushed
the
jreese-patch-1
branch
from
31bf07e
to
5a07600
Compare
Will build on 3.6 and 3.7, on Linux and Mac. Updates makefile to use `python` instead of `python3` because Windows is weird. Windows builds will come later when better support for spawned processes is added.
amyreese
force-pushed
the
jreese-patch-1
branch
from
5a07600
to
f894e32
Compare
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=========================================
Coverage ? 79.15%
=========================================
Files ? 12
Lines ? 801
Branches ? 77
=========================================
Hits ? 634
Misses ? 143
Partials ? 24Continue to review full report at Codecov.
|
Will build on 3.6 and 3.7, on Linux and Mac. Windows builds will be added once it is fully supported in Bowler, because Github Actions don't currently support the notion of jobs that are allowed to fail. Also drops the Travis CI config and switches to Codecov instead of Coveralls for test coverage reports.