Preserve Mesh instancing

[davilovick]

glTF allows to have several Nodes sharing the same Mesh.

It would be great if FBX2glTF supports that feature :)
Several FbxNode instances can share the same FbxMesh (obtained by the getMesh() method), but right now the code allways creates a new mesh, instead of using the mesh created before in that cases (File: Fbx2Raw.cpp, line 895)

Best regards,
David Ávila Membrives
Wave Engine team member

[zellski]

You're finding some prime bugs, @davilovick! Much appreciated. This is obviously a major deal; instancing is critical. We just never happened to use it in any of our past work, so it never came up. Adding to 1.0 release criteria.

[davilovick]

Thanks! Great work
I'm working on integrating glTF as the 3D model pipeline in WaveEngine (www.waveengine.net). And we are dealing the FBX conversion with this awesome tool :)

Best regards!

[davilovick]

Here I've created a PR that solves that issue :)
#46

[zellski]

Fantastic! Celebrating Thanksgiving here at the moment, but thanks so much for the PR; I'll look it over ASAP.

[zellski]

Teapots work great! This .fbx however does not:

fir.zip

It should look like:

but instead it looks like:

Pretty tragic. I'm going to dig in a bit and see I can figure out what's going on.

[zellski]

Oh -- of course. It's the node name collision bug again. That's on me to fix.

I'll accept your PR & just do the little stye tweaks myself. Thanks again!