Modify FBX2glTF to allow that several nodes share the same mesh. #46
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Overall this looks great. I added a few nitpick comments. Your teapot example loads perfectly and I verified that three.js does the right thing: there's just one single geometry, referenced by five nodes.
I was hoping this would also fix a model I have, that uses instancing... but no such luck. Not sure what's going on there. I'll write more about it in the issue.
| T &result = *iter->second; | ||
| return result; | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe we should make this available in a common header file...
| @@ -284,7 +293,7 @@ ModelData *Raw2Gltf( | |||
|
|
|||
| std::map<std::string, std::shared_ptr<NodeData>> nodesByName; | |||
| std::map<std::string, std::shared_ptr<MaterialData>> materialsByName; | |||
| std::map<std::string, std::shared_ptr<MeshData>> meshByNodeName; | |||
| std::map<long, std::shared_ptr<MeshData>> meshBySurfaceId; | |||
There was a problem hiding this comment.
Can you fix up the indentation here (and anywhere else)?
| std::string nodeName = rawSurface.nodeName; | ||
| NodeData &meshNode = require(nodesByName, nodeName); | ||
| int surfaceId = rawSurface.id; | ||
| //NodeData &meshNode = require(nodesByName, nodeName); |
There was a problem hiding this comment.
Let's not leave commented-out code -- just nuke the line.
| auto meshIter = meshByNodeName.find(nodeName); | ||
| if (meshIter != meshByNodeName.end()) { | ||
| MeshData *mesh = nullptr; | ||
| auto meshIter = meshBySurfaceId.find(surfaceId); |
|
Great! Thanks |
I've changed the code to allow several node shares the same mesh.
Here you can find a test to test that feature:
https://drive.google.com/open?id=1CKbDGCX2wSo8VpP07vwLsEjuEZxftc3K
It produces only 1 mesh, and 5 nodes that uses the same mesh.
Best regards,
David Ávila