Fix async events UserData key mapping. #32
Conversation
|
@HeyMultiverse @josejia if possible could someone please review and merge this? Historically it looks like no one ever gets around to PR reviews in a timely fashion for this repo and having to reapply patches every time a WordPress plugin updates is a headache. |
|
+1 for accepting this PR. As WP users upgrade to PHP 8+ this will become an ever increasing issue. |
|
+1 bump etc etc Please maintain your official plugins |
Summary: The keys in the normalized data were incorrectly associated to the single value constructor variants; since the UserData normalization encodes arrays, the multiple value constructor variants should be used.
|
Bump. Getting to be a little ridiculous now at almost 3 months... @fbisaso, maybe you could take a look at this? |
|
This is ridiculous. How can a multi billion company fail in such simple tasks. Like what are you even doing. Everybody is getting error messages for which there seems to be a seemingly easy fix, but you guys do not even care as it seems. Merge that commit already!!! |
|
What is most infuriating is that @Invader444 has already done the work for you on this simple fix. Just accept the PR already. Geez. |
|
The sad part is, none of these comments get their attention. I also tried to comment on all the related bug reports on the wordpress.org support forum for this plugin with a link to this PR... and still silence from Facebook. |
|
@fbisaso has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Bump? Hello? Anything? |
|
The issue is that the array values should be plural? that seems odd. |
|
Hello @facebook-github-bot we all need a fix |
|
Guessing this plugin is no longer active. |
|
I applied this change locally in the plugin and didn't fix the bug... Are you sure this will fix it? |
|
still throws same error |
|
Interesting, are you sure you didn't typo @pedronastasi? It fixed the issue for me when I wrote it... Have you restarted php-fpm in case your opcache settings don't detect changes to the source files? Just guessing here what the issue might be... On Dec 3, 2022 10:13 AM, pedronastasi ***@***.***> wrote:
still throws same error
tipo E_ERROR en la línea 42 del archivo /var/www/html/wp-content/plugins/official-facebook-pixel/vendor/facebook/php-business-sdk/src/FacebookAds/Object/ServerSide/Normalizer.php. Mensaje de error: Uncaught TypeError: strlen(): Argument #1 ($string) must be of type string, array given in /var/www/html/wp-content/plugins/official-facebook-pixel/vendor/facebook/php-business-sdk/src/FacebookAds/Object/ServerSide/Normalizer.php:42
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@Invader444 has updated the pull request. You must reimport the pull request before landing. |
|
Wow, until now it wasn't updated :( |
|
I wanted to apologize for the delay in reviewing and accepting this pull request. We appreciate the time and effort you put into this contribution, and we're sorry it took us so long to get back to you. That being said, I'm happy to inform you that your changes have been accepted and will soon be merged into the main branch of our plugin. |
Summary: #32 Reviewed By: vahidkay-meta Differential Revision: D44457641 fbshipit-source-id: 5008689e616b09d7633ddb40e90b31651cee4a33
Summary: Release V3.0.9 * Removed hard coded OpenBridge Javascript * Fix async events UserData key mapping. #32 * Delay pixel events firing, to track engaged visitors * Bug Fixes Reviewed By: vahidkay-meta Differential Revision: D44620289 fbshipit-source-id: 25581b15056a8b1d68474650bd7f3e8eb70c1388
|
Since this PR has been implemented into version 3.0.9, you might consider closing this PR |
Summary:
The keys in the normalized data were incorrectly associated to the single value constructor variants; since the UserData normalization encodes arrays, the multiple value constructor variants should be used.