Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container #240

Merged
merged 6 commits into from
Aug 15, 2023
Merged

Fix container #240

merged 6 commits into from
Aug 15, 2023

Conversation

l50
Copy link
Contributor

@l50 l50 commented Aug 15, 2023 •
edited

Proposed Changes

This PR simplifies the container building process, removes redundant setups, and updates relevant documentation.

Related Issue(s)

Testing

  1. Pulled the branch locally and tested the "Reopen in Container" option in VSCode.
  2. Followed the steps in the updated documentation to pull and run the bash container locally.
  3. Verified that the GitHub Actions workflow runs without errors for this PR.
  4. Ensured the container action works as expected (https://github.com/facebookincubator/TTPForge/actions/runs/5863799165).

Documentation

Updated the documentation to reflect the removal of the ZSH container and to remove references to building the ZSH base image.

Screenshots/GIFs (optional)

Not applicable.

Checklist

  • Ran mage runprecommit locally and fixed any issues that arose.
  • Ran mage runtests locally and fixed any issues that arose.
  • Curated your commits so they are legible and easy to read and understand.
  • 🚀

@l50
Add python3-venv package and restructure Dockerfile to create a virtu…
b4a981d 
…al environment for pre-commit

- Added the python3-venv package to the dependencies.
- Created a virtual environment and installed pre-commit within it.
- Organized the Dockerfile to copy the codebase and set up the virtual environment before other installations.
- Updated the directory ownership for the ttpforge user.
@l50
Removed zsh container; updated action accordingly
ab36ec4
@l50
Remove container branch from build action
5686ac0
@l50
Updated container doc and devcontainer name
5df52f0
@l50
Updated devcontainer and ensured Dockerfile worked with it
1da2341
@l50 l50 added area/github Changes made to github actions area/docs Changes made in the docs directory labels Aug 15, 2023
@l50 l50 changed the title Container Fix container Aug 15, 2023
@l50 l50 requested a review from cedowens August 15, 2023 06:44
@d3sch41n d3sch41n merged commit af563be into main Aug 15, 2023
2 checks passed
@d3sch41n d3sch41n deleted the container branch August 15, 2023 13:12
@d3sch41n
Copy link
Contributor

cool - merged in will test today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3sch41n d3sch41n d3sch41n approved these changes

@CrimsonK1ng CrimsonK1ng Awaiting requested review from CrimsonK1ng CrimsonK1ng is a code owner

@cedowens cedowens Awaiting requested review from cedowens cedowens is a code owner

Assignees
No one assigned
Labels
area/docs Changes made in the docs directory area/github Changes made to github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚨 [BUG] - Fix container
3 participants
@l50 @d3sch41n @facebook-github-bot