Fix procfs when reading cgroup membership #8106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@brianc118 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
When reading cgroup membership, we currently assume that the cgroup v2 line will be first in /proc/[pid]/cgroup. This is not necessarily the case. Instead let's take the first line that starts with "0::". Tested on ubuntu where ``` $ cat /proc/1/cgroup 12:blkio:/init.scope 11:pids:/init.scope 8:memory:/init.scope 7:freezer:/ 4:devices:/init.scope 2:cpu,cpuacct:/init.scope 1:name=systemd:/init.scope 0::/init.scope ```
brianc118
force-pushed
the
procfs-pid-fix
branch
from
a6bf684
to
a0a3355
Compare
|
@brianc118 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@brianc118 merged this pull request in c3af8c1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading cgroup membership, we currently assume that the cgroup v2
line will be first in /proc/[pid]/cgroup. This is not necessarily the
case. Instead let's take the first line that starts with "0::".
Tested on ubuntu where
This should fix #8105.